feat: trigger eic_container build to catch build errors #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
topic: infrastructure
wdconinc
force-pushed
the
trigger-container
branch
from
96fcc1a
to
d875618
Compare
wdconinc
force-pushed
the
trigger-container
branch
from
d875618
to
60aade3
Compare
|
This PR now triggers eic_container builds, and then indirectly the containers for both default and nightly. At some point we can fix the container to only trigger default when the container is triggered by an epic geometry push. |
veprbl
previously approved these changes
Sep 19, 2024
wdconinc
force-pushed
the
trigger-container
branch
from
d939847
to
bb126e6
Compare
veprbl
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR causes changes in this repository to trigger a container rebuild on eicweb to catch errors like https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/2955907 during container build which don't happen during detector benchmark custom build. Ultimately this should make the detector benchmark trigger unnecessary and simplify the workflows with which our benchmark pipelines are activated.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.