Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bic geo adjustment #729

Merged
merged 3 commits into from
May 22, 2024
Merged

Bic geo adjustment #729

merged 3 commits into from
May 22, 2024

Conversation

mariakzurek
Copy link
Contributor

@mariakzurek mariakzurek commented May 17, 2024

Briefly, what does this PR introduce?

Changes the size of Barrel ECal to the current envelope r=82 cm, length in z = 435 cm (active SciFi/Pb matrix).
Removes the Aluminum support planes of SciFi/Pb, and replaces them with thicker Carbon Fiber planes according to the newest geometry.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes

@mariakzurek
Copy link
Contributor Author

Fig. 1 shows one example AstroPix layer with CF plates that are 0.2 cm thick (dz = 0.1).
Fig. 2 shows example SciFi/Pb sector that has only SciFi/Pb-Glue and Pb-Glue edge slices material, no Aluminum anymore.
Fig1
Fig2

Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wdconinc wdconinc added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit e52f76a May 22, 2024
109 checks passed
@wdconinc wdconinc deleted the bic-geo-adjustment branch May 22, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants