Modified .cpp file and adding the parameter section to the xml file #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
github-actions
bot
added
topic: backward
wdconinc
reviewed
Jun 4, 2024
billlee77
force-pushed
the
739-moving-hard-coded-pfrich-parameters-to-the-xml-file
branch
from
a8a311d
to
efb1ebf
Compare
|
@wdconinc The number conversion part is addressed, please take one more look and approve the PR |
…' of github.com:eic/epic into 739-moving-hard-coded-pfrich-parameters-to-the-xml-file
billlee77
force-pushed
the
739-moving-hard-coded-pfrich-parameters-to-the-xml-file
branch
from
fd570cf
to
c850e71
Compare
for more information, see https://pre-commit.ci
|
We see there is an overlap now, we are working on fixing it. |
|
@wdconinc @kkauder @RomanTkachenko-dev The overlap issue is resolved, please consider merging after the checks. |
|
Do we understand the failed checks? |
|
@wdconinc Hi Wouter, could you take a look a the auto-check result this time, the only thing that is not finished is the physics benchmark. Is this expected? |
veprbl
approved these changes
Jun 24, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
…743) ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Np --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kkauder
deleted the
739-moving-hard-coded-pfrich-parameters-to-the-xml-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Np