nHCal fix rotated segmentation #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 layers with 4 cm steel and 0.4 cm scintillator Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
Signed-off-by: lkosarz <[email protected]>
…nto negative-HCal-dev
Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/hcal/hcal_backward.xml Signed-off-by: lkosarz <[email protected]>
Removed empty environments Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Restored rmin and rmax to the decector parameter table Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/hcal/backward.xml Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
…nto nHCal-positionFix # Conflicts: # compact/definitions.xml Signed-off-by: lkosarz <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
…tion Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/display.xml # compact/hcal/backward_endcap_flux.xml # configurations/arches.yml # configurations/brycecanyon.yml # configurations/central.yml # src/EndcapFluxReturn_geo.cpp Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
for more information, see https://pre-commit.ci
veprbl
reviewed
Jun 20, 2024
Signed-off-by: Kosarzewski <[email protected]>
veprbl
previously approved these changes
Jun 20, 2024
|
Can you also address failing overlap checks: https://github.com/eic/epic/actions/runs/9601322569/job/26479729341?pr=748 |
added 2 commits
June 20, 2024 13:51
Signed-off-by: Kosarzewski <[email protected]>
…nto nHCal-positionFix
|
I did test these overlaps and somehow couldn't believe they are real. Now I fixed them |
veprbl
approved these changes
Jun 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Tests have been performed
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?