Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit on material #754

Merged

Conversation

billlee77
Copy link
Contributor

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • [x ] New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • [ x] Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

No

@billlee77 billlee77 linked an issue Jul 16, 2024 that may be closed by this pull request
@github-actions github-actions bot added topic: backward Negative-rapidity detectors (electron-going side) topic: PID Particle identification labels Jul 16, 2024
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I have code organization suggestions.

src/PFRICH_geo.cpp Outdated Show resolved Hide resolved
src/PFRICH_geo.cpp Outdated Show resolved Hide resolved
src/PFRICH_geo.cpp Outdated Show resolved Hide resolved
src/PFRICH_geo.cpp Outdated Show resolved Hide resolved
billlee77 and others added 2 commits July 27, 2024 13:25
…ion-study' of github.com:eic/epic into 750-correcting-material-of-pfrich-components-for-radiation-study
src/PFRICH_geo.cpp Outdated Show resolved Hide resolved
@veprbl veprbl added this to the 24.08.0 milestone Jul 31, 2024
@billlee77
Copy link
Contributor Author

@wdconinc @kkauder

Hi Wouter and Kolja, the PR is ready for review and merge

@veprbl veprbl added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 6fbf993 Aug 2, 2024
113 checks passed
@veprbl veprbl deleted the 750-correcting-material-of-pfrich-components-for-radiation-study branch August 2, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: backward Negative-rapidity detectors (electron-going side) topic: PID Particle identification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correcting material of pfRICH components for radiation study
2 participants