Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove FileLoader symlink unconditionally #762

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: remove FileLoader symlink unconditionally #762

merged 1 commit into from
Jul 26, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

This PR modifies the FileLoader to remove the hash symlink unconditionally, whether broken or not. This should fix an issue where the symlink exists, points to another symlink, and that is a dead link.

What kind of change does this PR introduce?

  • Bug fix (issue: permission denied error)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@wdconinc wdconinc requested a review from veprbl July 25, 2024 20:38
@wdconinc wdconinc enabled auto-merge July 25, 2024 21:14
@wdconinc wdconinc added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit e1dfc99 Jul 26, 2024
115 checks passed
@wdconinc wdconinc deleted the rm-symlink branch July 26, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants