Update material map #764
Merged
Update material map #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschmookler
approved these changes
Aug 12, 2024
|
Comparison
|
wdconinc
approved these changes
Aug 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
see https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/153#note_27817 ### Briefly, what does this PR introduce? update material map for the new inner MPGD ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? N/A ### Does this PR change default behavior? should improve the tracking performance (cherry picked from commit a00759c)
|
Successfully created backport PR for |
wdconinc
pushed a commit
that referenced
this pull request
Aug 12, 2024
# Description Backport of #764 to `24.08`. Co-authored-by: ShujieL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://eicweb.phy.anl.gov/EIC/detectors/athena/-/issues/153#note_27817
Briefly, what does this PR introduce?
update material map for the new inner MPGD
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
N/A
Does this PR change default behavior?
should improve the tracking performance