Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increased size of cells in HG part of insert from 2.16 to 2.34 cm. #783

Closed
wants to merge 5 commits into from

Conversation

sebouh137
Copy link
Contributor

The purpose of this is to reduce the number of channels to a more manageable number.

Briefly, what does this PR introduce?

Increases the size of the HG part of the insert from 2.16 cm to 2.34.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: parameter change

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

no

Does this PR change default behavior?

yes. Slightly larger tiles in the HG part of the insert.

…e purpose of this is to reduce the number of channels to a more manageable number.
@github-actions github-actions bot added topic: forward Positive-rapidity detectors (hadron-going side) topic: calorimetry labels Sep 17, 2024
@sebouh137 sebouh137 marked this pull request as ready for review September 17, 2024 21:55
@sebouh137
Copy link
Contributor Author

@wdconinc Do you know why the "linux-eic-shell / validate-material-map (pull_request)" check is failing? Is this something that's been going on for a while?

@wdconinc
Copy link
Contributor

@wdconinc Do you know why the "linux-eic-shell / validate-material-map (pull_request)" check is failing? Is this something that's been going on for a while?

Related to the upgrade of acts, but not clear yet why exactly. Unrelated to this PR.

@sebouh137
Copy link
Contributor Author

@rymilton could you approve this pull request?

@veprbl
Copy link
Member

veprbl commented Sep 25, 2024

This change got merged in #785

@veprbl veprbl closed this Sep 25, 2024
auto-merge was automatically disabled September 25, 2024 01:33

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: calorimetry topic: forward Positive-rapidity detectors (hadron-going side)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants