Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): don't trigger geoviewer directly #794

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

Now that we trigger the geoviewer from the container job, along with other benchmarks, we don't need to trigger it directly (and it doesn't work to trigger it directly). E.g. https://eicweb.phy.anl.gov/EIC/benchmarks/geoviewer/-/jobs/3948345 triggered by https://github.com/eic/epic/actions/runs/11263980547/job/31323141281 just uses epic-main in the container, not the update-sensor-geometry-for-RP it should be using.

This PR removes the direct trigger of the geoviewer.

What kind of change does this PR introduce?

  • Bug fix (issue: )
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

@github-actions github-actions bot added the topic: infrastructure Regarding build system, CI, CD label Oct 11, 2024
@veprbl veprbl enabled auto-merge October 17, 2024 22:40
@veprbl veprbl added this pull request to the merge queue Oct 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 20, 2024
@veprbl veprbl added this pull request to the merge queue Oct 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 21, 2024
@veprbl veprbl added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 4bb200f Oct 22, 2024
80 checks passed
@veprbl veprbl deleted the geoviewer-through-container-trigger branch October 22, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Regarding build system, CI, CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants