Femcal update by akioogawa · Pull Request #855 · eic/epic

akioogawa · 2025-05-02T13:02:18Z

Briefly, what does this PR introduce?

New Forward EM calorimeter geometry with current design. There are 2 models, homogeneous and Wpowder+ScFi.
Also removes active insert, which won't be built.
See following links for some more details:
https://www.star.bnl.gov/~akio/epic/geometry/index.html
https://www.star.bnl.gov/~akio/epic/reco/index.html
https://www.star.bnl.gov/~akio/epic/hadron/index.html

What kind of change does this PR introduce?

Bug fix (issue #__)
New feature (issue #__)
Documentation update
Other: __

Please check if this PR fulfills the following:

Tests for the changes have been added
Documentation has been added / updated
Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

See also PR for EICrecon for digitization change
eic/EICrecon#1848

Does this PR change default behavior?

Not until default configuration files start to use new geometry

better solution

for more information, see https://pre-commit.ci

akioogawa · 2025-05-02T20:30:29Z

Auto check uses craterlake for overlap checks. Do I change craterlake (and all other craterlake_*)?

veprbl · 2025-05-02T20:58:37Z

Auto check uses craterlake for overlap checks. Do I change craterlake (and all other craterlake_*)?

Yes, please update all configurations to use your new xml.

veprbl

I have some preliminary comments.

configurations/craterlake_newfEcal.yml

configurations/fecal+h.yml

configurations/fecal.yml

configurations/fecal_scfi.yml

src/forwardEcalMap.h

src/forwardEcalScFi_geo.cpp

for more information, see https://pre-commit.ci

akioogawa · 2025-11-12T13:18:39Z

I think the overlap is now gone. 2 pending checks after 1/2 day. Anything else?

akioogawa · 2025-11-12T16:14:33Z

I have no idea what those 2 failed check are : nvidia-smi & sim:zdc_lyso

for more information, see https://pre-commit.ci

veprbl

Have a question about segmentation. I think, we should make it into a consistent bit field for both implementations.

compact/ecal/forward_ScFi.xml

akioogawa · 2025-11-14T17:33:42Z

Confimed that removing fake segmantation runs ok. Not sure what I saw 1/2 year ago. I tested it repeatedly. Anyway thanks for all those changes.

### Briefly, what does this PR introduce? Following Forward EM calorimeter geometry update: eic/epic#855 this provides switch between Homogeneous and ScFi geometry implementations based on xml file loaded - For Homogenous, we keep energy smearing as is. SF=1.0 - For ScFi, hits from fibers are summed to a tower and no enrgy smearing applied. SF=0.03. - Remove active insert which won't be built Added an option to put SiPM saturation to CalorimeterHitDigi - Specify 2 new parameters : totalPixel and nPhotonPerGeV - default for totalPixel is 0, which case no attenuation is applied - For FEMC for both geometry models, SiPM saturation is ON by default - Use "-PFEMC:SiPMSaturation=OFF" to turn it off See following links for some more details: https://www.star.bnl.gov/~akio/epic/geometry/index.html https://www.star.bnl.gov/~akio/epic/reco/index.html https://www.star.bnl.gov/~akio/epic/hadron/index.html ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? I don't think so, unless one provides wrong config xml file (until sum check in place) ### Does this PR change default behavior? It does apply SiPM attenuation by default for FEMC (but not other calorimeters). --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com> Co-authored-by: Wouter Deconinck <wdconinc@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

veprbl · 2025-11-18T15:46:16Z

Some benchmark plots from https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/pipelines/132524

akioogawa · 2025-11-18T16:25:38Z

src/forwardEcal_geo.cpp

+            pv = trow_vol.placeVolume(
+                tower_vol,
+                Transform3D(RotationZYX(0, 0, 0), Position((tc - 1.5) * blocksize / 4, 0, 0)));
+            pv.addPhysVolID("tower_x", tc);


I thought you changed this to "x". Same for "y" above? @veprbl

### Briefly, what does this PR introduce? This is a hotfix for #855 (comment) (we should probably run a benchmark on scfi version) ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Yes

Akio Ogawa and others added 6 commits March 5, 2025 09:17

initial version of fEcal update with current design

463e91c

include beam pipe protector instead of insert.h

0c3a786

z location update, new yml files, and hit update

0259f97

Adding a version with actual 760 ScFi

3ae5445

adding fake CartesianGridXY for ScFi hits for speed while looking for

ca908f4

better solution

hit and detector name back to original. Small bug fix in map

2ab0ad8

github-actions bot added topic: calorimetry topic: materials labels May 2, 2025

[pre-commit.ci] auto fixes from pre-commit.com hooks

f133db2

for more information, see https://pre-commit.ci

akioogawa mentioned this pull request May 2, 2025

Update FEMC for new geometry: eic/EICrecon#1848

Merged

7 tasks

akioogawa and others added 3 commits May 2, 2025 09:40

Merge branch 'main' into fEcal_update

f908817

spdx

d2f94ee

[pre-commit.ci] auto fixes from pre-commit.com hooks

8326c34

for more information, see https://pre-commit.ci

changing craterlake.yml for auto overlap check

15db2d2

veprbl reviewed May 2, 2025

View reviewed changes

akioogawa and others added 6 commits May 2, 2025 17:16

Delete configurations/craterlake_newfEcal.yml

be6af38

just renaming

76a7834

name change

8026edc

rename preparing for merging

cea4eb1

Merging 2 geo.cpp

6d07ce2

[pre-commit.ci] auto fixes from pre-commit.com hooks

71a470a

for more information, see https://pre-commit.ci

This comment was marked as resolved.

Sign in to view

akioogawa and others added 6 commits May 5, 2025 12:05

switching to new forward ecal geometry in all confiugration

18dcd8f

Fix typo which caused a crash

0b7b36f

[pre-commit.ci] auto fixes from pre-commit.com hooks

5d53535

for more information, see https://pre-commit.ci

Merge branch 'main' into fEcal_update

89b3f8e

fix overlap with mother volume for bpp

44985a4

[pre-commit.ci] auto fixes from pre-commit.com hooks

2ee4f7e

for more information, see https://pre-commit.ci

Merge branch 'main' into fEcal_update

abf4250

veprbl and others added 6 commits November 12, 2025 11:29

remove configurations/becal.yml (use imaging_only.yml)

4c9f4e9

remove commented code in xmls

e3849f7

forwardEcal_geo.cpp: remove old hardcoding

6079c20

src/forwardEcalMap.h: remove some unused constants

69e5da0

Merge remote-tracking branch 'origin/main' into fEcal_update

f6ff9ef

[pre-commit.ci] auto fixes from pre-commit.com hooks

6d14183

for more information, see https://pre-commit.ci

veprbl reviewed Nov 12, 2025

View reviewed changes

compact/ecal/forward_ScFi.xml Outdated Show resolved Hide resolved

compact/ecal/forward_ScFi.xml Outdated Show resolved Hide resolved

veprbl added 2 commits November 13, 2025 19:36

Use NoSegmentation

fa442d5

tower_x,tower_y -> x,y

272589b

veprbl previously approved these changes Nov 14, 2025

View reviewed changes

naming

8dd888b

veprbl dismissed their stale review via 8dd888b November 14, 2025 01:18

naming2

0783137

veprbl previously approved these changes Nov 14, 2025

View reviewed changes

Merge branch 'main' into fEcal_update

f0b4f5e

veprbl dismissed their stale review via f0b4f5e November 14, 2025 14:19

rename3

a0ac51d

Merge branch 'main' into fEcal_update

c526dd2

veprbl approved these changes Nov 18, 2025

View reviewed changes

veprbl merged commit 3b0f0be into main Nov 18, 2025
161 checks passed

veprbl deleted the fEcal_update branch November 18, 2025 15:46

akioogawa commented Nov 18, 2025

View reviewed changes

veprbl mentioned this pull request Nov 18, 2025

forwardEcal_geo: Adjust readout names to match updated xml #1001

Merged

7 tasks

Conversation

akioogawa commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

Please check if this PR fulfills the following:

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

Uh oh!

akioogawa commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

veprbl commented May 2, 2025

Uh oh!

veprbl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

akioogawa commented Nov 12, 2025

Uh oh!

akioogawa commented Nov 12, 2025

Uh oh!

veprbl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

akioogawa commented Nov 14, 2025

Uh oh!

veprbl commented Nov 18, 2025

Uh oh!

Uh oh!

akioogawa Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

akioogawa commented May 2, 2025 •

edited

Loading

akioogawa commented May 2, 2025 •

edited

Loading

akioogawa Nov 18, 2025 •

edited

Loading