-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npdet_to_step cannot handle TGeoTessellation #21
Comments
7 tasks
github-merge-queue bot
pushed a commit
to eic/epic
that referenced
this issue
Mar 24, 2024
### Briefly, what does this PR introduce? This PR exports the geometry to STEP files for CAD import and dimensioning. There are no real settings to tweak, but to increase the level at which volumes are exported, hints can be added to the yaml file. Detectors can also be removed (currently only the ACTS subassemblies are removed since they don't do anything). There are 'issues' that need to be addressed, but they have to be addressed in npsim: - units are off (npdet_to_step use the cm value from TGeo and writes them as inch values in STEP) eic/npsim#20, - some shapes cannot be exported; not sure yet which ones and it makes more sense to bypass them in npsim eic/npsim#21. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Dmitry Kalinkin <[email protected]>
wdconinc
added a commit
to eic/epic
that referenced
this issue
Mar 25, 2024
### Briefly, what does this PR introduce? This PR exports the geometry to STEP files for CAD import and dimensioning. There are no real settings to tweak, but to increase the level at which volumes are exported, hints can be added to the yaml file. Detectors can also be removed (currently only the ACTS subassemblies are removed since they don't do anything). There are 'issues' that need to be addressed, but they have to be addressed in npsim: - units are off (npdet_to_step use the cm value from TGeo and writes them as inch values in STEP) eic/npsim#20, - some shapes cannot be exported; not sure yet which ones and it makes more sense to bypass them in npsim eic/npsim#21. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? No. --------- Co-authored-by: Dmitry Kalinkin <[email protected]>
7 tasks
wdconinc
added a commit
that referenced
this issue
Apr 10, 2024
### Briefly, what does this PR introduce? This PR adds support for TGeoTessellated volumes in the export to STEP. Storing meshes in STEP is not really the most efficient way (BHCAL is 71MB as STEP), but it simplifies some workflows. ### What kind of change does this PR introduce? - [x] Bug fix (issue #21) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? Yes, adds support for TGeoTessellated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment: (where does this bug occur, have you tried other environments)
main
for latest released):HEAD
for the most recent on git):Steps to reproduce: (give a step by step account of how to trigger the bug)
/opt/detector/setup.sh
npdet_to_step part -l 4 HcalBarrel -o bhcal $DETECTOR_PATH/epic_bhcal.xml
Expected Result: (what do you expect when you execute the steps above)
Should export STEP file.
Actual Result: (what do you get when you execute the steps above)
Due to
npsim/src/geocad/src/TGeoToOCC.cxx
Line 223 in c3bde04
Two step resolution:
npsim/src/geocad/src/TOCCToStep.cxx
Line 93 in c3bde04
npsim/src/geocad/src/TOCCToStep.cxx
Line 119 in c3bde04
npsim/src/geocad/src/TGeoToOCC.cxx
Line 130 in c3bde04
The text was updated successfully, but these errors were encountered: