host addr is now using usize to support 32 bit host #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Section enum was using `usize` for virtual addresses, which caused truncation on 32-bit platforms (e.g., RISC-V zkVM). VM addresses like MM_RODATA_START (0x100000000) would truncate to 0 when cast to 32-bit usize, causing "Access violation in program section" errors. This change distinguishes between: - VM addresses (always u64 per sBPF spec) - Host addresses (native usize for memory pointers) Changes: - Section::Owned and Section::Borrowed now use u64 for VM addresses - parse_ro_sections() uses u64 for lowest_addr, highest_addr, ro_slices - Removed truncating `as usize` casts for MM_RODATA_START - Updated test assertions to compare map() results with `as u64`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.