[Deps] Update finn-hlslib #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After switching to the recent finn-hlslib version (dev branch), the ap_float header is included by default whenever you are using some operation which requires the flatten function (e.g. attention, elementwise-binary). However, ap_float requires Vitis HLS 2024.2 while we are still stuck on 2022.2... For now this is a workaround, I'd like to properly fix this via some feature test macros conditionally disabling compilation of the float section...