Specialize handling of incorrect VCDs for single bit case #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
commented
Jul 10, 2025
| @@ -800,6 +786,19 @@ impl SignalEncoder { | |||
| }); | |||
| self.max_states = States::join(self.max_states, states); | |||
| } else { | |||
| let value_bits: &[u8] = match value[0] { | |||
| b'b' | b'B' => &value[1..], | |||
| _ => value, | |||
There was a problem hiding this comment.
I wonder if this is ever triggered now? It can be replaces with
let value_bits: &[u8] = &value[1..];and the tests still pass.
oscargus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
A bit tricky to tell exactly how much is saved due to thermal throttling and running other stuff (to some extent), but before:
After:
so I think slightly above 10%.
These are running wave2saif on a 2.2 GB post-synthesis VCD file.