Allow disabling default addons with Auto Mode #8165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello artem-nefedov 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website
artem-nefedov
force-pushed
the
fix-disable-default-addons-auto
branch
from
0353633 to
a41adc9
Compare
a-hilaly
previously approved these changes
Jan 28, 2025
gustavodiaz7722
previously approved these changes
Jan 28, 2025
auto-merge was automatically disabled
January 29, 2025 14:46
Head branch was pushed to by a user without write access
artem-nefedov
dismissed stale reviews from gustavodiaz7722 and a-hilaly
via
7dbf08e
artem-nefedov
force-pushed
the
fix-disable-default-addons-auto
branch
from
7dbf08e to
304feb6
Compare
artem-nefedov
force-pushed
the
fix-disable-default-addons-auto
branch
from
304feb6 to
1ffa301
Compare
gustavodiaz7722
approved these changes
Jan 29, 2025
a-hilaly
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VPC CNI is not needed in Auto Mode for IRSA/IAM pod identity to function, and it's not installed as "default addon" with Auto Mode either way.
Fixes #8164
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯