Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang.org/x/crypto from v0.22.0 to v0.32.0 #8166

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Bump golang.org/x/crypto from v0.22.0 to v0.32.0 #8166

merged 2 commits into from
Jan 28, 2025

Conversation

gustavodiaz7722
Copy link
Contributor

@gustavodiaz7722 gustavodiaz7722 commented Jan 28, 2025 •
edited
Loading

Description

Bumping golang.org/x/crypto to v0.32.0, due to known CVE with v0.22.0.

  1. Upgrade dependency using go get golang.org/x/crypto@latest
  2. Run go mod tidy
  3. Install build dependencies make install-build-deps and do first time build make build.
  4. run the following make generate-all && make lint && make check-all-generated-files-up-to-date
  5. Commit all changes to the workspace, including any changes that were auto generated.
  6. Generate new image tags make -f Makefile.docker update-build-image-tag
  7. Commit all changes that were auto generated.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@gustavodiaz7722 gustavodiaz7722 added dependencies Pull requests that update a dependency file kind/improvement labels Jan 28, 2025
a-hilaly
a-hilaly previously approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

a-hilaly
a-hilaly approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gustavodiaz7722 gustavodiaz7722 merged commit 7979b9f into eksctl-io:main Jan 28, 2025
11 checks passed
This was referenced Jan 28, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gustavodiaz7722 @a-hilaly