Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for setting MarketType/InstanceMarketOptions for use with "capacity-block" #8207

Conversation

dims
Copy link
Contributor

@dims dims commented Feb 11, 2025

Needed for enabling/using Capacity Blocks for ML

Ensures that LaunchTemplateData will end up with InstanceMarketOptions/MarketType when CapacityReservation/CapacityReservationID is set like so:

managedNodeGroups:
  - name: cbr
    instanceType: p5en.48xlarge
    minSize: 2
    maxSize: 2
    availabilityZones: ["us-east-2c"]  # Match AZ where reservation is deployed
    capacityReservation:
      capacityReservationTarget:
        capacityReservationId: "cr-028e8bdd6334b8012"  # Replace with your ML Capacity Block ID
    instanceMarketOptions:
      marketType: capacity-block

Notes:

  • instanceMarketOptions can only be specified when there is a capacityReservation section
  • "capacity-block" is the only accepted value for marketType
  • capacityReservationId is passed through and is not validated, so watch your cloud formation stack to see any potential issues.

Resolves #8155

@bryantbiggs bryantbiggs added kind/feature New feature or request area/nodegroup labels Feb 11, 2025
@dims dims changed the title [WIP] Support for setting MarketType/InstanceMarketOptions for use with "capacity-block" Support for setting MarketType/InstanceMarketOptions for use with "capacity-block" Feb 11, 2025
@dims dims force-pushed the support-for-setting-markettype-instance-market-options-for-use-with-capacity-block branch from 0160459 to 089e445 Compare February 13, 2025 23:31
@dims dims force-pushed the support-for-setting-markettype-instance-market-options-for-use-with-capacity-block branch from 089e445 to e53cf1d Compare February 14, 2025 02:30
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit 854da87 into eksctl-io:main Feb 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/nodegroup kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add support for Capacity Blocks in eksctl config file schema
2 participants