Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update building with golang 1.24 #8210

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Update building with golang 1.24 #8210

merged 1 commit into from
Feb 13, 2025

Conversation

cheeseandcereal
Copy link
Member

@cheeseandcereal cheeseandcereal commented Feb 12, 2025

Description

This CR is bumping the eksctl build/system to golang 1.24. This includes multiple dependency updates as well.

The main build image has been updated to accommodate this.

Everything is building and passing all checks locally. Will confirm that actions continue to work after this change as well.

Some integration test fixes were also included for this.

Resolves #8209

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@cheeseandcereal cheeseandcereal added the area/tech-debt Leftover improvements in code, testing and building label Feb 12, 2025
@cheeseandcereal cheeseandcereal force-pushed the update-golang branch 3 times, most recently from c914e51 to dc761c1 Compare February 12, 2025 23:07
@cheeseandcereal cheeseandcereal marked this pull request as ready for review February 12, 2025 23:59
Also update build image manifest, tag file and workflows
Copy link
Contributor

@TiberiuGC TiberiuGC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@cheeseandcereal cheeseandcereal merged commit 1482694 into main Feb 13, 2025
9 checks passed
@cheeseandcereal cheeseandcereal deleted the update-golang branch February 13, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Build fails with Go 1.24
2 participants