Update GPU ec2 instance types in integration tests #8217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheeseandcereal
added
area/testing
skip-release-notes
bryantbiggs
reviewed
Feb 13, 2025
| @@ -924,7 +924,7 @@ var _ = Describe("(Integration) Create, Get, Scale & Delete", func() { | |||
| "--timeout=45m", | |||
| "--cluster", params.ClusterName, | |||
| "--nodes", "1", | |||
| "--instance-types", "p3.2xlarge,p3.8xlarge,g3s.xlarge,g4ad.xlarge,g4ad.2xlarge", | |||
| "--instance-types", "g6.xlarge,g6.2xlarge", | |||
There was a problem hiding this comment.
should work but might run into insufficient capacity with this type FYI
if we go a bit larger to 4x, 8x, 16x - the price won't be too drastic given its run a short duration but there will be more available capacity (customers avoid these because they really need the GPUs, not the added vCPU/memory - so they all aim for the x, 2x size)
There was a problem hiding this comment.
Yeah. I wanted to try using another instance type entirely, but they're either also old or gigantic (like the P5 instances start at 24xl).
We can try this for now, and then if there are issues adjust
bryantbiggs
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the instance types used in the integration tests to stop using P3 or G4ad instances which are much older. P3 instances are scheduled for retiring at some point, so we should stop using them.
Replaced with more modern equivalents.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯