Fix get iamserviceaccount returning error for unrelated CloudFormation Stack #8350
+478
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 8, 2025 21:44
naclonts
changed the title
naclonts
commented
Apr 16, 2025
| @@ -24,8 +24,8 @@ var _ = Describe("Get", func() { | |||
| irsaManager = irsa.New("my-cluster", fakeStackManager, nil, nil) | |||
| }) | |||
|
|
|||
| When("no options are specified", func() { | |||
| It("returns all service accounts", func() { | |||
| When("no error occurs", func() { | |||
There was a problem hiding this comment.
Most of the logic that these tests covered is now in GetIAMServiceAccounts, with test coverage in iam_test.go.
cheeseandcereal
previously approved these changes
Apr 17, 2025
|
Note you need to rebase this because of the conflicts with go.mod/go.sum that have changed since you made this |
cheeseandcereal
approved these changes
Apr 17, 2025
cheeseandcereal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where, if one IAM service account had errors creating,
eksctl get iamserviceaccountwould fail even when filtering for different service accounts. See issue report for more details: #8314Closes #8314
The problem was that the
managerpackage'sGetIAMServiceAccountsqueried all CloudFormation stacks and returned an error for any service account that it finds, before filtering the service account based on the user's CLI filters.This PR moves the filtering prior to the error returning, meaning errors will only be returned if the error was in a stack that the user is including in their filter.
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯