Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar UX #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sidebar UX #20

wants to merge 1 commit into from

Conversation

infogulch
Copy link
Collaborator

@infogulch infogulch commented May 7, 2022

Orient sidebar buttons vertically, as described in #16 (comment). This will conflict with 16; that PR should probably be merged first and I'll rebase this one on top of it after.

Changes:

  • Orient buttons vertically, with the chevron in the top right corner. This makes it easier to add more buttons, and also makes the buttons clickable on mobile.
  • Adjust the spacing of the sidebar and Notebook so that the sidebar and buttons are always visible, even with a very narrow view. It's a tiny bit off-center at this width but worth actually being able to interact with the UI.
  • Add small border to the right of the sidebar, visible on cell hover, and small cell padding left to space it. This makes it easier to see which input and output views are part of the same cell; this was visually confusing at first and will get worse as we add more views to cells.
  • Remove FaChevronDown in favor of a conditional rotate-90 transform class when the input is shown. Combined with transition-all this nicely animates the chevron when you click on the sidebar.
  • Only show delete button when input is visible, this helps prevent taps on the invisible delete button on mobile (for closed cells at least), and works around an issue on closed markdown cells with one line where the delete button sticks out below the bottom of the sidebar.
  • Adjust the positioning calculation of the sidebar so that the left side reaches just to the edge of the view, not far past. This will make it easier to position items in the sidebar in general, and covers the case where the page is very zoomed out and 2000px is not enough. Generally this is minor but feels more 'correct' to me.

@infogulch infogulch changed the title Vertical sidebar & UI details; step towards mobile compat Vertical sidebar buttons & UI details; step towards mobile compat May 7, 2022
@infogulch infogulch changed the title Vertical sidebar buttons & UI details; step towards mobile compat Sidebar UX May 8, 2022
@infogulch infogulch requested a review from ekzhang June 17, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant