Enhance Event API addTrack endpoint
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting tracks and add new VTT test files, fixes #36
ferishili
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #36,
Description
regarding new subtitle mechanism in Opencast called "subtitle-rework", the newly introduced api event endpoint
addTrackwas not working properly since it could handlecaption/sourceand tags with lang flags.On the other hand, the overwriteExisting flag was not working properly, meaning no update or delete was taking placing by passing that flag.
What has been Added/Fixed
OcEventsApi::addTrackmethod, whihc can handle string format as well as array formataddTrackendpoint have been expanded in a way that it covers all the scenarios including add, update and delete!NOTE