Add opencast.external_api_node config value
#1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
status:conflicts
This allows admins to override which OC node is used for external API operations. Previously, `sync_node` was used, which was not always correct. Fixes elan-ev#1216
LukasKalbertodt
force-pushed
the
delete-video-node
branch
from
23e63b2 to
4124484
Compare
github-actions
bot
removed
the
status:conflicts
| @@ -30,6 +30,7 @@ pub(crate) async fn run(shared: &args::Shared, args: &Args) -> Result<()> { | |||
| }; | |||
| let meili = check_meili(&config).await; | |||
| let opencast_sync = check_opencast_sync(&config).await; | |||
| let oc_external_api = check_external_api(&config).await; | |||
There was a problem hiding this comment.
opencast_ vs. oc_ triggers me slightly. 😐
Comment on lines
32
to
+33
| let opencast_sync = check_opencast_sync(&config).await; | ||
| let oc_external_api = check_external_api(&config).await; |
There was a problem hiding this comment.
It's slightly unfortunate that both of these have to create an Opencast client. 🤔
Comment on lines
+75
to
+78
| pub(crate) fn external_api_node(&self) -> &HttpHost { | ||
| self.external_api_node.as_ref().unwrap_or_else(|| self.unwrap_host()) | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the third instance of this pattern, at which point I personally would want a thing for it. 😅
|
We decided that none of the comments block this from merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows admins to override which OC node is used for external API
operations. Previously,
sync_nodewas used, which was not alwayscorrect.
Fixes #1216