Add caching for Paella SVG icons #1500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly, the `settings.svg` has to be treated in a special way. We could have disabled caching+hashing for it, but that would also be ugly. So I decided to just pass this one hashed file via frontend config.
LukasKalbertodt
force-pushed
the
cache-paella-icons
branch
from
b45ce67 to
743f03f
Compare
owi92
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that these icons are downloaded every time, which takes a lot of time. Not sure why we never did that before. I guess I assumed the paths are hardcoded deep inside Paella, but no: we can just replace them in
theme.json.