Fix "global page admins" appearing in ACL UI for events/series #1502
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only makes sense for realm ACL, as there global page admins magically have access. Before this commit, for users that were global page admins, the entry was also shown in the ACL UI for events and series.
Otherwise, it looks bad on some screen widths.
owi92
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only makes sense for realm ACL, as there global page admins magically have access. Before this commit, for users that were global page admins, the entry was also shown in the ACL UI for events and series.
You can test that easily on the deployment with user
gustav(same password asadmin). He cannot upload but just check out any video he has access to like https://tobira.opencast.org/~manage/videos/P-R1lPy_-q_/access. Check the same on this PR's deployment to see the entry disappear.CC @oas777