Add keyboard shortcuts for general functions and video player #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owi92
added
area:frontend
This is mostly copied over from Opencast Studio as we aim for a coherent design and user experience. Player shortcuts will be added in the next commit.
These are mostly the same ones that are used in Youtube videos and on similar platforms, working within the constraints of the paella player. Unfortunately, one does not simply replace paella's icons (I don't think it's imposible though), but in the interest of time this will have to do without any icons (that would be shown when a shortcut is activated). Note: This needs the next commit to work properly on multi-video pages.
This will now track which player is currently active, so shortcuts will only register for that video.
This makes sure that the default behaviour (i.e. scroll by pressing the spacebar) will only be prevented if there is an active video player on the current page (scrolling is still prevented in other standard cases, for example when a button is focused – this will also not trigger the shortcut). It should be noted that once a player is active, scrolling with space will no longer be possible at all on the current page instance. Also, and this is definitely a point for further discussion: Shortcuts will be activated once the player is loaded. That means the user has to click or otherwise trigger the play button first before they can use any shortcuts. This might be annoying to some (I personally do not like that necessity).
... hopefully. Apparently, `ParseKeys` was resolving to `any` in the previous iteration's union type. If this doesn't help, I guess I'll just remove the first part of the union and be content with having to add an extra object level for all keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following shortcuts:
Note that right now, the play shortcut cannot be used to start a video yet, only to pause and resume play. I do realize that this is suboptimal and am looking for a solution.
Also, the "general" section is pretty bare bones, but I could imagine adding some more shortcuts, for example for changing the language or color scheme. On the other hand I would not add shortcuts for every single conceivable action.
Review commit by commit.
Resolves #1416