Conversation
- replaced overflow_container and secondary_overflow with single overflow_containers setting (comma-separated)
- added configurable "Trash to Dump" section, instead of hardcoded herb/food/junk
|
Probably want to remove food, herb, and junk toggles in the sell type section since they are covered by the trash to dump section. |
I kept old functionality that it still checks the "sell" types in order to then trash/junk stuff. So you have to have both checked in order to actually dump. Couldn't think of a better way to safeguard. That way it tries to sell first any category and then dumps (just for food/herbs/junk it can't really sell, but still needed to be checked) |
force saving of migrated settings for overflow upon migration
Updated the total tips calculation to include a custom withdraw amount setting for the locksmith.
Refactor in_region method to improve boundary check logic and add a bugfix for destination room check.
Add comment to clarify bounty town region check
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 5415732 in 27 seconds. Click for details.
- Reviewed
653lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_y0gZZGwCMQS4BsSN
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Fixed bug in keep scrolls option to skip non-numeric entries.
Important
This PR updates
eloot.licto use a single overflow container setting, adds configurable trash dump types, and includes various bug fixes and improvements.overflow_containerandsecondary_overflowwithoverflow_containers(comma-separated) ineloot.lic.trash_dump_typessetting, replacing hardcoded herb/food/junk.--sellable/type/sellCLI.single_drag_boxcycling through all group disks whenuse_disk_groupis false.migrate_overflow_settings()to convert old overflow settings to new format.sacks_fullto store additional information.This description was created by
for 5415732. You can customize this summary. It will automatically update as commits are pushed.