Fix NullReferenceException in TryToCompressRegular method in Span

[JeremyBessonElastic]

Fix NullReferenceException in method TryToCompressRegular of Span

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[gregkalapos]

Change looks good to me.

It'd be nice to have a test covering this. So far my idea how this could happen: if the span is not sampled, then Context won't be populated. My guess is that the span that causes the nullref here is unsampled. So all the requirements for compression are met, but there is no Context.

@JeremyBessonElastic have you tried reproducing this? I'd try by creating a span that is unsampled, and meets all the requirements for compression (leave span, with short duration).

I'd not spend too much time on it, but maybe worth trying to reproduce it and cover it with a test.

[gregkalapos]

I tried to verify my theory above with unsampled spans - that does not seem to reproduce the issue - this method we fix here is not called for unsampled spans.

With that, I think the best is to merge this and see if this fixes the problem.