Test with jdk 24 and 25 ea #3949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKunz
added
the
ci:jdk-compatibility
|
We'll keep this PR around and monitor the inferred spans support closer to release. |
github-actions
bot
added
community
JonasKunz
added
ci:jdk-compatibility
github-actions
bot
added
community
github-actions
bot
added
community
JonasKunz
commented
May 27, 2025
| @@ -116,7 +116,7 @@ | |||
| <!-- -dependencies versions --> | |||
| <version.error_prone>2.2.0</version.error_prone> | |||
| <version.h2>1.4.196</version.h2> | |||
| <version.junit>5.9.1</version.junit> | |||
| <version.junit>5.12.2</version.junit> | |||
There was a problem hiding this comment.
JUnit had to be updated to include the newer java versions in @DisabledForJRE
| static synchronized void initAllButInstrumentation() { | ||
| ElasticApmAgent.reset(); // reset the AbstractInstrumentationTest beforeAll initialization |
There was a problem hiding this comment.
The JUnit upgrade made the lambda tests fail.
They apparently have been relieing on a bug where static @BeforeAll methods from subclasses would replace static @BeforeAll in parent methods. Now they both execute, causing the tracer to be initialized twice.
|
we lose inferred spans after 23? |
jackshirazi
approved these changes
May 27, 2025
Yes, due to async-profiler 1.x not working correctly there. We will need to upgrade it to support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Tests with Java 24 ea to ensure that the blocked bytebuddy-bump #3946 doesn't bite us.
Once we get notified by the
JdkVersionTestabout the release of Java 24, we can simply remove the-easuffix and drop java 23 from the list.