fix labeler + automaticaly add to GH project #4037

SylvainJuge · 2025-04-03T13:38:30Z

fixes the agent-java label
automatically adds internal PRs to the project board in In Progress status and in current iteration with something reusable across projects.

SylvainJuge · 2025-04-04T10:29:25Z

.github/workflows/labeler.yml

+      uses: AlexanderWert/issue-labeler@32be4a3c3d8f009c2741af471994337c34b4cb6f  # v2.3
      with:
-        script: |
-          github.rest.issues.addLabels({
-            issue_number: context.issue.number,
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            labels: ["agent-java"]
-          })
+        repo-token: "${{ secrets.GITHUB_TOKEN }}"
+        configuration-path: .github/java-label.yml
+        enable-versioned-regex: 0


[for reviewer] this part failed, so switching to the same pattern we have elsewhere for example in the android agent seem to work. Also, I wonder if we could/should replace the current version as it relies on Alex repository.

SylvainJuge · 2025-04-04T10:30:19Z

.github/workflows/labeler.yml

+    - name: Check team membership for user
+      uses: elastic/[email protected]
+      id: checkUserMember
      with:
-        github-org: "elastic"
-        github-user: ${{ github.actor }}
-        github-token: ${{ steps.get_token.outputs.token }}
+        username: ${{ github.actor }}
+        team: 'apm'
+        usernamesToExclude: |
+          apmmachine
+          dependabot
+          dependabot[bot]
+        GITHUB_TOKEN: ${{ steps.get_token.outputs.token }}
+
+    - name: Show team membership
+      run: |
+        echo "::debug::isTeamMember: ${{ steps.checkUserMember.outputs.isTeamMember }}"
+        echo "::debug::isExcluded: ${{ steps.checkUserMember.outputs.isExcluded }}"

    - name: Add community and triage labels
-      if: contains(steps.is_elastic_member.outputs.result, 'false') && github.actor != 'dependabot[bot]' && github.actor != 'elastic-renovate-prod[bot]' && github.actor != 'elastic-observability-automation[bot]'
-      uses: actions/github-script@v7
+      if: steps.checkUserMember.outputs.isTeamMember != 'true' && steps.checkUserMember.outputs.isExcluded != 'true'
+      uses: AlexanderWert/issue-labeler@32be4a3c3d8f009c2741af471994337c34b4cb6f  # v2.3
      with:
-        script: |
-          github.rest.issues.addLabels({
-            issue_number: context.issue.number,
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            labels: ["community", "triage"]
-          })
-    - name: Add comment for community PR
-      if: contains(steps.is_elastic_member.outputs.result, 'false') && github.actor != 'dependabot[bot]' && github.actor != 'elastic-renovate-prod[bot]' && github.actor != 'elastic-observability-automation[bot]'
-      uses: wow-actions/auto-comment@2fc064c21cfb2505de3c5c10e1473b8eb7beca1a  # v1.1.2
-      with:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        pullRequestOpened: |
-          👋 @{{ author }} Thanks a lot for your contribution! 
-
-          It may take some time before we review a PR, so even if you don’t see activity for some time, it **does not** mean that we have forgotten about it. 
-
-          Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming [milestone](https://github.com/elastic/apm-agent-java/milestones). The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.
-    - name: Assign new internal pull requests to project
-      uses: elastic/[email protected]
-      if: contains(steps.is_elastic_member.outputs.result, 'true') && github.event.pull_request
+        repo-token: "${{ secrets.GITHUB_TOKEN }}"
+        configuration-path: .github/community-label.yml
+        enable-versioned-regex: 0


[for reviewer] this part is a copy-paste from android agent repo.

.github/workflows/labeler.yml

SylvainJuge · 2025-04-04T14:14:59Z

draft PR to add those to global github actions and make it easier to reuse elastic/oblt-actions#260

SylvainJuge · 2025-04-04T15:42:33Z

.github/workflows/labeler.yml

+        status_field_json=$(gh api graphql -f query='query($project_id:ID!){ node(id:$project_id){ ... on ProjectV2 { fields(first:20) { nodes { ... on ProjectV2SingleSelectField { id name options { id name } } } } } } }' --jq '.data.node.fields.nodes[]|select(.name=="Status")' -F project_id=${project_id})
+        status_field_id=$( echo "$status_field_json" | jq -r '.id' )
+        status_field_value_id=$( echo "$status_field_json" | jq -r ".options[]|select(.name==\"${STATUS}\")|.id" )
+        gh project item-edit --id "${item_id}" --project-id "${project_id}" --field-id "${status_field_id}" --single-select-option-id "${status_field_value_id}"
+
+        agent_field_json=$(gh api graphql -f query='query($project_id:ID!){ node(id:$project_id){ ... on ProjectV2 { fields(first:20) { nodes { ... on ProjectV2SingleSelectField { id name options { id name } } } } } } }' --jq '.data.node.fields.nodes[]|select(.name=="Agent")' -F project_id=${project_id})
+        agent_field_id=$(echo "$agent_field_json" | jq -r '.id' )
+        agent_field_value_id=$(echo "$agent_field_json" | jq -r ".options[]|select(.name==\"${AGENT}\")|.id" )
+        gh project item-edit --id "${item_id}" --project-id "${project_id}" --field-id "${agent_field_id}" --single-select-option-id "${agent_field_value_id}"
+
+        iteration_field_json=$(gh api graphql -f query='query($project_id:ID!){ node(id:$project_id) { ... on ProjectV2 { fields(first: 20) { nodes { ... on ProjectV2IterationField { id name configuration { iterations { startDate id } } } } } } } }' --jq '.data.node.fields.nodes[] | select( .name == "Iteration" )' -F project_id=${project_id})
+        iteration_field_id=$(echo "$iteration_field_json" | jq -r '.id' )
+        iteration_field_value_id=$(echo "$iteration_field_json" | jq -r 'last(.configuration.iterations[]|select(.startDate<=(now|strftime("%Y-%m-%d"))))|.id')
+        gh project item-edit --id "${item_id}" --project-id "${project_id}" --field-id "${iteration_field_id}" --iteration-id "${iteration_field_value_id}"


@v1v for now setting the field values does not work with the "project-field-set" action, however here this part is working as expected, removing the if condition allows to make it run with the expected result. I'm giving up on this for today, let's continue on this next week when you have time.

add new way to check permissions

d78f954

github-actions bot added the agent-java label Apr 3, 2025

SylvainJuge added 16 commits April 3, 2025 16:08

align with android repo

2f62718

add workflow dispatch

176c21d

disable add label

308a9f9

restove project assignment

9078e61

add to project board

8261560

try to set agent

2fd6835

remove condition on PR

5d16ba0

provide gh token

4581b8d

first working draft

2a00ba9

use test PR URL

2c9364f

remove test PR url and make it ready for use

4057a7e

restore java-agent label

7d4d097

use hardcoded issue ID

3aeeab9

use issue-labeler

c2e1fc5

remove warning for unused config option

89d98a5

restore it

0ba129d

SylvainJuge added agent-java and removed agent-java labels Apr 4, 2025

SylvainJuge requested a review from v1v April 4, 2025 10:27

SylvainJuge commented Apr 4, 2025

View reviewed changes

SylvainJuge requested a review from kuisathaverat April 4, 2025 10:37

SylvainJuge changed the title ~~wip issue/pr label/dispatch~~ fix labeler + automaticaly add to GH project Apr 4, 2025

try to reuse common code

ef08e7f

try to fix token

1abad94

SylvainJuge marked this pull request as draft April 4, 2025 14:45

SylvainJuge added 2 commits April 4, 2025 16:45

reuse set status

b9460c9

fix test url

a64f6f3

SylvainJuge added 2 commits April 4, 2025 17:25

try to set agent field

095df8b

try to set iteration

a3993e9

SylvainJuge self-assigned this Apr 4, 2025

SylvainJuge commented Apr 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix labeler + automaticaly add to GH project #4037

fix labeler + automaticaly add to GH project #4037

SylvainJuge commented Apr 3, 2025 •

edited

Loading

SylvainJuge Apr 4, 2025

SylvainJuge Apr 4, 2025

SylvainJuge commented Apr 4, 2025

SylvainJuge Apr 4, 2025

fix labeler + automaticaly add to GH project #4037

Are you sure you want to change the base?

fix labeler + automaticaly add to GH project #4037

Conversation

SylvainJuge commented Apr 3, 2025 • edited Loading

SylvainJuge Apr 4, 2025

Choose a reason for hiding this comment

SylvainJuge Apr 4, 2025

Choose a reason for hiding this comment

SylvainJuge commented Apr 4, 2025

SylvainJuge Apr 4, 2025

Choose a reason for hiding this comment

SylvainJuge commented Apr 3, 2025 •

edited

Loading