-
Notifications
You must be signed in to change notification settings - Fork 227
#2114 repeating query in django view #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xrmx
merged 8 commits into
elastic:main
from
Pokapiec:2114-repeating-query-in-django-view
Jul 10, 2025
Merged
#2114 repeating query in django view #2158
xrmx
merged 8 commits into
elastic:main
from
Pokapiec:2114-repeating-query-in-django-view
Jul 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed |
cla/check |
xrmx
reviewed
Dec 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we shouldn't poke much with Django internals, also we should not assume django is installed
@xrmx can you proceed reviewing this PR ? |
@pawelusermoc @Pokapiec pushed another commit to cleanup, does it work for you? |
xrmx
reviewed
Jul 7, 2025
xrmx
approved these changes
Jul 7, 2025
trentm
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
In this PR i add another condition to
elif
statement inutils.encoding.transform
function to handle displaying representation of django QuerySet object in custom way. We need to do it because if we try to executerepr
function on unexecutedQuerySet
which causes Timeout on database, it will execute byutils.encoding.transform
function.I also added a simple test simulating database Timeout.
Related issues
Closes #2114