psycopg: fix cursor execute and executemany signatures #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Moved to draft, need also to update elasticapm/instrumentation/packages/asyncio/psycopg_async.py |
Adapt CursorProxy._trace_sql to take into account other keyword arguments passed to it.
Adapt AsyncCursorProxy._trace_sql to take into account other keyword arguments passed to it.
xrmx
force-pushed
the
psycopg-cursor-execute-update
branch
from
fd46708 to
0e3dea5
Compare
basepi
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adapt {Async,}CursorProxy._trace_sql to take into account other keyword arguments passed to it.
Related issues
Closes #2293