fix(rum-angular): capture angular navigation errors #1662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsJust comment with:
|
🔍 Preview links for changed docs |
david-luna
changed the title
david-luna
changed the title
vigneshshanmugam
previously approved these changes
Dec 2, 2025
Member
vigneshshanmugam
left a comment
vigneshshanmugam
left a comment
There was a problem hiding this comment.
LGTM, added few nits - but no blocking comments.
packages/rum/src/index.d.ts
Outdated
| } | ||
| } | ||
| type Payload = { | ||
| transactions: TransactionPayload[] |
Member
There was a problem hiding this comment.
nit: I forgot if we explicitly exclude the fields from Transaction, can we do Partial and omit few keys?
Member
Author
There was a problem hiding this comment.
okay, I'll leave id, type and name
Member
Author
There was a problem hiding this comment.
commit abc965d
I've made also Span and Error partial
package.json
Outdated
| "engines": { | ||
| "node": ">=12 <=16", | ||
| "npm": "6" | ||
| "node": "^20.19.0 || ^22.12.0 || >=24.0.0" |
Member
There was a problem hiding this comment.
why not >= 20? as nvmrc uses 20 ?
vigneshshanmugam
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Angular integration will now capture navigation errors
Fixes: #1660
This PR also add a small extra check for payloads that have been modified by
addFilterAPI. For that we updated the type definitions of the filter function so users will have more assistance in their IDEsFixes: #1658
Closes: #1659