-
Notifications
You must be signed in to change notification settings - Fork 533
Reintroduce fleetctl as tool #13444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Reintroduce fleetctl as tool #13444
Conversation
removed in elastic#13440 from systemtests but still can be useful for development or manual testing purposes
This pull request does not have a backport label. Could you fix it @endorama? 🙏
NOTE: |
I don't think we need to backport this PR. |
This pull request is now in conflicts. Could you fix it @endorama? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks did would have been helpful for some recent configs we added to the integrations package
This pull request is now in conflicts. Could you fix it @endorama? 🙏
|
We recently removed
fleetctl
in #13440 as it's no longer used in test, and was part ofsystemtest
.But there is still use for it as a standalone tool to aid development and manual testing, so I'm proposing this PR that moves it in
tools/
This change adds a direct dependency between
tools
andsystemtest
, but the same dependency was present, indirectly, before this PR so I don't consider it a blocker.We may want to refactor
systemtest/fleettest
to split the concerns, but I'm not sure it's worth the effort at this moment.