Skip to content

Commit 37a915c

Browse files
committed
Replace docker-compose by 'docker compose'
The docker Compose V1 (docker-compose) stopped receiving updates on July 2023, this PR updates our automation tools to use the new Compose V2 (docker compose). Compose V2 has been GA since April 2022. More information on https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/.
1 parent 89cd840 commit 37a915c

File tree

8 files changed

+21
-19
lines changed

8 files changed

+21
-19
lines changed

CHANGELOG-developer.next.asciidoc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ The list below covers the major changes between 7.0.0-rc2 and main only.
7070
- Debug log entries from the acker (`stateful ack ...` or `stateless ack ...`) removed. {pull}39672[39672]
7171
- Rename x-pack/filebeat websocket input to streaming. {issue}40264[40264] {pull}40421[40421]
7272
- Journald input now calls `journalctl` instead of using `github.com/coreos/go-systemd/[email protected]/sdjournal`, the CGO dependency has been removed from Filebeat {pull}40061[40061]
73+
- Use Docker Compose V2 (`docker compose`) instead of Compose V1 (`docker-compose`) {pull}40890[40890]
7374

7475
==== Bugfixes
7576

dev-tools/mage/common.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -216,12 +216,12 @@ func dockerInfo() (*DockerInfo, error) {
216216
return &info, nil
217217
}
218218

219-
// HaveDockerCompose returns an error if docker-compose is not found on the
219+
// HaveDockerCompose returns an error if docker is not found on the
220220
// PATH.
221221
func HaveDockerCompose() error {
222-
_, err := exec.LookPath("docker-compose")
222+
_, err := exec.LookPath("docker")
223223
if err != nil {
224-
return fmt.Errorf("docker-compose is not available")
224+
return fmt.Errorf("docker is not available")
225225
}
226226
return nil
227227
}

dev-tools/mage/integtest_docker.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ func (d *DockerIntegrationTester) Test(dir string, mageTarget string, env map[st
141141
composeEnv,
142142
os.Stdout,
143143
os.Stderr,
144-
"docker-compose",
145-
args...,
144+
"docker",
145+
append([]string{"compose"}, args...)...,
146146
)
147147

148148
err = saveDockerComposeLogs(dir, mageTarget)
@@ -313,8 +313,8 @@ func BuildIntegTestContainers() error {
313313
composeEnv,
314314
out,
315315
os.Stderr,
316-
"docker-compose", args...,
317-
)
316+
"docker",
317+
append([]string{"compose"}, args...)...)
318318

319319
// This sleep is to avoid hitting the docker build issues when resources are not available.
320320
if err != nil {
@@ -324,8 +324,8 @@ func BuildIntegTestContainers() error {
324324
composeEnv,
325325
out,
326326
os.Stderr,
327-
"docker-compose", args...,
328-
)
327+
"docker",
328+
append([]string{"compose"}, args...)...)
329329
}
330330
return err
331331
}
@@ -348,8 +348,8 @@ func StartIntegTestContainers() error {
348348
composeEnv,
349349
os.Stdout,
350350
os.Stderr,
351-
"docker-compose",
352-
args...,
351+
"docker",
352+
append([]string{"compose"}, args...)...,
353353
)
354354
return err
355355
}
@@ -370,7 +370,7 @@ func StopIntegTestContainers() error {
370370
composeEnv,
371371
ioutil.Discard,
372372
out,
373-
"docker-compose",
373+
"docker", "compose",
374374
"-p", DockerComposeProjectName(),
375375
"rm", "--stop", "--force",
376376
)
@@ -428,7 +428,7 @@ func saveDockerComposeLogs(rootDir string, mageTarget string) error {
428428
composeEnv,
429429
composeLogFile, // stdout
430430
composeLogFile, // stderr
431-
"docker-compose",
431+
"docker", "compose",
432432
"-p", DockerComposeProjectName(),
433433
"logs",
434434
"--no-color",

libbeat/tests/compose/wrapper.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ func (d *wrapperDriver) cmd(ctx context.Context, command string, arg ...string)
168168
}
169169
args = append(args, command)
170170
args = append(args, arg...)
171-
cmd := exec.CommandContext(ctx, "docker-compose", args...)
171+
cmd := exec.CommandContext(ctx, "docker", append([]string{"compose"}, args...)...)
172172
cmd.Stdout = os.Stdout
173173
cmd.Stderr = os.Stderr
174174
if len(d.Environment) > 0 {

testing/environments/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
ENV?=snapshot.yml
2-
BASE_COMMAND=docker-compose -f ${ENV} -f local.yml
2+
BASE_COMMAND=docker compose -f ${ENV} -f local.yml
33

44
start:
55
# This is run every time to make sure the environment is up-to-date

x-pack/winlogbeat/module/testing.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func testIngestPipeline(t *testing.T, pipeline, pattern string, p *params) {
8181
t.Fatal(err)
8282
}
8383
if *wintest.KeepRunning {
84-
fmt.Fprintln(os.Stdout, "Use this to manually cleanup containers: docker-compose", "-p", devtools.DockerComposeProjectName(), "rm", "--stop", "--force")
84+
fmt.Fprintln(os.Stdout, "Use this to manually cleanup containers: docker compose", "-p", devtools.DockerComposeProjectName(), "rm", "--stop", "--force")
8585
}
8686
t.Cleanup(func() {
8787
stop := !*wintest.KeepRunning

x-pack/winlogbeat/module/wintest/docker.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func saveLogs(env map[string]string, root, target string) error {
7878
env,
7979
f, // stdout
8080
f, // stderr
81-
"docker-compose",
81+
"docker", "compose",
8282
"-p", devtools.DockerComposeProjectName(),
8383
"logs",
8484
"--no-color",
@@ -140,7 +140,8 @@ func dockerCompose(env map[string]string, verbose bool) error {
140140
env,
141141
out,
142142
os.Stderr,
143-
"docker-compose", args...,
143+
"docker",
144+
append([]string{"compose"}, args...)...,
144145
)
145146
if err == nil {
146147
break

x-pack/winlogbeat/module/wintest/simulate_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ func TestSimulate(t *testing.T) {
4848
t.Fatal(err)
4949
}
5050
if *wintest.KeepRunning {
51-
fmt.Fprintln(os.Stdout, "docker-compose", "-p", devtools.DockerComposeProjectName(), "rm", "--stop", "--force")
51+
fmt.Fprintln(os.Stdout, "docker compose", "-p", devtools.DockerComposeProjectName(), "rm", "--stop", "--force")
5252
}
5353
t.Cleanup(func() {
5454
stop := !*wintest.KeepRunning

0 commit comments

Comments
 (0)