Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #39871) Migrate github checks to buildkite for packetbeat and x-pack/packetbeat #39875

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 12, 2024

Proposed commit message

Migrate github checks to buildkite for packetbeat and x-pack/packetbeat

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs


This is an automatic backport of pull request #39871 done by [Mergify](https://mergify.com).

…at (#39871)

* update

* update

(cherry picked from commit f8679db)

# Conflicts:
#	.github/workflows/check-packetbeat.yml
@mergify mergify bot requested a review from a team as a code owner June 12, 2024 13:15
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 12, 2024
Copy link
Contributor Author

mergify bot commented Jun 12, 2024

Cherry-pick of f8679db has failed:

On branch mergify/bp/7.17/pr-39871
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit f8679db91a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/packetbeat/pipeline.packetbeat.yml
	modified:   .buildkite/x-pack/pipeline.xpack.packetbeat.yml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: .github/workflows/check-packetbeat.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2024
@ev1yehor ev1yehor added Team:Ingest-EngProd and removed conflicts There is a conflict in the backported pull request labels Jun 13, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 13, 2024
@ev1yehor ev1yehor requested a review from a team as a code owner June 13, 2024 13:09
@ev1yehor ev1yehor requested review from AndersonQ and belimawr and removed request for a team June 13, 2024 13:09
Copy link
Contributor Author

mergify bot commented Jun 17, 2024

This pull request has not been merged yet. Could you please review and merge it @ev1yehor? 🙏

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this appears to be a clean backport that's passing, but I think we may need to address the equivalent of #39870 (comment) in a subsequent PR?

@ev1yehor ev1yehor merged commit 8416710 into 7.17 Jun 17, 2024
22 checks passed
@ev1yehor ev1yehor deleted the mergify/bp/7.17/pr-39871 branch June 17, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants