Skip to content

Conversation

@faec
Copy link
Contributor

@faec faec commented Aug 9, 2024

A stray := instead of = overwrote the intended queue metrics namespace. This PR fixes it and adds a test to make sure the correct namespace is used.

Fixes #40477

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec added the bug label Aug 9, 2024
@faec faec self-assigned this Aug 9, 2024
@faec faec requested a review from a team as a code owner August 9, 2024 17:39
@faec faec requested review from AndersonQ and leehinman August 9, 2024 17:39
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 9, 2024
@faec faec added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 9, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 9, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mergify
Copy link
Contributor

mergify bot commented Aug 9, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @faec? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@faec faec added the backport-8.15 Automated backport to the 8.15 branch with mergify label Aug 9, 2024
@cmacknz
Copy link
Member

cmacknz commented Aug 9, 2024

Once these are working, do we have to follow up and add them to the elastic_agent package as well so they are visualized in Fleet? https://github.com/elastic/integrations/tree/main/packages/elastic_agent

@faec
Copy link
Contributor Author

faec commented Aug 9, 2024

Once these are working, do we have to follow up and add them to the elastic_agent package as well so they are visualized in Fleet?

Yes, #39774 just added raw metrics to libbeat, it didn't add visualizations for any of the new fields.

@faec faec merged commit d7ae68c into elastic:main Aug 9, 2024
@faec faec deleted the queue-monitoring-fix branch August 9, 2024 20:02
mergify bot pushed a commit that referenced this pull request Aug 9, 2024
A stray `:=` instead of `=` overwrote the intended queue metrics namespace. This PR fixes it and adds a test to make sure the correct namespace is used.

Fixes #40477

(cherry picked from commit d7ae68c)
@cmacknz
Copy link
Member

cmacknz commented Aug 9, 2024

Cool, make sure there is a follow up issue filed so we can make use of the new metrics once they are available, if you aren't planning to just take care of the update.

pierrehilbert pushed a commit that referenced this pull request Aug 10, 2024
A stray `:=` instead of `=` overwrote the intended queue metrics namespace. This PR fixes it and adds a test to make sure the correct namespace is used.

Fixes #40477

(cherry picked from commit d7ae68c)

Co-authored-by: Fae Charlton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.15 Automated backport to the 8.15 branch with mergify bug Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Queue Metrics missing/wrong in 8.15.0

3 participants