-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17](backport #40238) Go-based changeset definition for MODULE #40945
Conversation
Added MODULE env var definition within mage (cherry picked from commit cc0bda7) # Conflicts: # .buildkite/heartbeat/heartbeat-pipeline.yml # .buildkite/x-pack/pipeline.xpack.auditbeat.yml # .buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml # .buildkite/x-pack/pipeline.xpack.metricbeat.yml # .buildkite/x-pack/pipeline.xpack.winlogbeat.yml # x-pack/auditbeat/magefile.go
Cherry-pick of cc0bda7 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏 |
PTAL @alexsapran @belimawr @nfritts |
This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏 |
@@ -18,6 +18,8 @@ env: | |||
RACE_DETECTOR: "true" | |||
TEST_COVERAGE: "true" | |||
|
|||
BEAT_PATH: "x-pack/winlogbeat" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x-pack.winlogbeat didn't need the BEAT_PATH in the main branch? https://github.com/elastic/beats/blob/main/.buildkite/x-pack/pipeline.xpack.winlogbeat.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, it shouldn't be there. For x-pack/winlogbeat in Jenkinsfile within 7 steps running mage build unitTest
, only 1 has withModule
in both main and 7.17 - which seems to be an inconsistency. I have mentioned it here.
Will remove it.
This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏 |
Proposed commit message
Added MODULE env var definition within mage.
MODULE is set within invoking mage target, if there are changes brought by the PR, instead of calling separate bash-script to evaluate changes and define variable.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Logs
BK builds:
This is an automatic backport of pull request #40238 done by [Mergify](https://mergify.com).