Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #40238) Go-based changeset definition for MODULE #40948

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 23, 2024

Proposed commit message

Added MODULE env var definition within mage.
MODULE is set within invoking mage target, if there are changes brought by the PR, instead of calling separate bash-script to evaluate changes and define variable.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Logs

BK builds:


This is an automatic backport of pull request #40238 done by [Mergify](https://mergify.com).

Added MODULE env var definition within mage

(cherry picked from commit cc0bda7)
@mergify mergify bot requested review from a team as code owners September 23, 2024 09:44
@mergify mergify bot added the backport label Sep 23, 2024
@mergify mergify bot requested a review from a team as a code owner September 23, 2024 09:44
@mergify mergify bot requested review from mauri870 and khushijain21 and removed request for a team September 23, 2024 09:44
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 23, 2024
Copy link
Contributor

@oakrizan oakrizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean backport

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 23, 2024
@oakrizan oakrizan merged commit 2752910 into 8.x Sep 23, 2024
130 checks passed
@oakrizan oakrizan deleted the mergify/bp/8.x/pr-40238 branch September 23, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant