Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #41197) Adjust Beats container user to be numeric. #41280

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 17, 2024

Adjust Beats container user to be numeric.

"Recently" the user in the dockerfile was adjusted to be 1000 instead of metricbeat: https://github.com/elastic/beats/pull/35272/files#r1184217000

I believe this was recently changed here

See elastic/cloud-on-k8s#8086 (comment)
This is causing issues when running the container as runAsNonRoot: true:

container has runAsNonRoot and image has non-numeric user (metricbeat)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

This should only allow the container to run when runAsNonRoot: true is set.

Author's Checklist

  • Ensure the container builds in CI
  • Ensure e2e tests pass

How to test this PR locally

mage package I believe

Related issues

Signed-off-by: Michael Montgomery <[email protected]>
(cherry picked from commit a7915d8)
@mergify mergify bot requested a review from a team as a code owner October 17, 2024 07:45
@mergify mergify bot added the backport label Oct 17, 2024
@mergify mergify bot requested review from faec and leehinman and removed request for a team October 17, 2024 07:45
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 17, 2024
@botelastic
Copy link

botelastic bot commented Oct 17, 2024

This pull request doesn't have a Team:<team> label.

@rdner rdner enabled auto-merge (squash) October 17, 2024 08:16
@rdner rdner merged commit 01c1585 into 8.x Oct 17, 2024
142 checks passed
@rdner rdner deleted the mergify/bp/8.x/pr-41197 branch October 17, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants