Skip to content

[8.19](backport #46562) refactor: remove obsolete "version" property from Docker Compose files #46856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 29 commits into
base: 8.19
Choose a base branch
from
Open

[8.19](backport #46562) refactor: remove obsolete "version" property from Docker Compose files #46856

wants to merge 29 commits into from
+6 −96

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Sep 30, 2025

As specified here:

See this comment and issue for more context:

Removing the property gets rid of this warning displayed whenever using the files (e.g. running integration tests):

"the attribute version is obsolete, it will be ignored, please remove it to avoid potential confusion".

This is an automatic backport of pull request #46562 done by Mergify.

@mergify mergify bot added the backport label Sep 30, 2025
@mergify mergify bot requested review from a team as code owners September 30, 2025 13:28
@mergify mergify bot added the backport label Sep 30, 2025
@mergify mergify bot requested review from andrzej-stencel and mauri870 and removed request for a team September 30, 2025 13:28
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 30, 2025
@mergify mergify bot mentioned this pull request Sep 30, 2025
Merged
@github-actions github-actions bot added cleanup release-note:skip The PR should be ignored when processing the changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Sep 30, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 30, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 30, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mergify
Copy link
Contributor Author

mergify bot commented Oct 6, 2025

This pull request has not been merged yet. Could you please review and merge it @andrzej-stencel? 🙏

@andrzej-stencel andrzej-stencel enabled auto-merge (squash) October 7, 2025 12:09
@mergify
Copy link
Contributor Author

mergify bot commented Oct 13, 2025

This pull request has not been merged yet. Could you please review and merge it @andrzej-stencel? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Nov 3, 2025

This pull request has not been merged yet. Could you please review and merge it @andrzej-stencel? 🙏

@mauri870
Copy link
Member

mauri870 commented Nov 3, 2025

/test

@mergify
Copy link
Contributor Author

mergify bot commented Nov 10, 2025

This pull request has not been merged yet. Could you please review and merge it @andrzej-stencel? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Nov 17, 2025

This pull request has not been merged yet. Could you please review and merge it @andrzej-stencel? 🙏

@rdner rdner assigned rdner and unassigned andrzej-stencel Nov 17, 2025
@rdner
Copy link
Member

rdner commented Nov 17, 2025

I see the following test failures:

=== FAIL: metricbeat/module/aerospike/namespace TestFetch (186.02s)
logger.go:146: 2025-11-17T14:32:30.634Z DEBUG docker Docker client will negotiate the API version on the first request.
logger.go:146: 2025-11-17T14:32:30.636Z ERROR container remove: Error response from daemon: Conflict, cannot remove the default link name of the container
Found orphan containers (metricbeat_8_19_8_d4a5a26c38-snapshot_etcd_1, metricbeat_8_19_8_d4a5a26c38-snapshot_mysql_1) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.

I'm investigating. Strange that it's not failing the same way on main.

@rdner rdner disabled auto-merge November 17, 2025 16:01
@rdner
Copy link
Member

rdner commented Nov 17, 2025

In 938341c I'm trying out something that docker-compose suggested in its output. If it works, I'll open a PR to main with this change and then backport to all active branches.

@rdner
Copy link
Member

rdner commented Nov 17, 2025

#46856 (comment) – this didn't help and the tests are passing locally on my machine. I suspect it has something to do with the Docker version itself. I'm reverting 938341c

@mergify
Copy link
Contributor Author

mergify bot commented Nov 24, 2025

This pull request has not been merged yet. Could you please review and merge it @rdner? 🙏

@rdner rdner enabled auto-merge (squash) November 24, 2025 09:18
@rdner
Copy link
Member

rdner commented Nov 24, 2025

/test

@mergify
Copy link
Contributor Author

mergify bot commented Dec 1, 2025

This pull request has not been merged yet. Could you please review and merge it @rdner? 🙏

@rdner rdner assigned andrzej-stencel and unassigned rdner Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauri870 mauri870 mauri870 approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

Assignees

@andrzej-stencel andrzej-stencel

Labels

backport cleanup release-note:skip The PR should be ignored when processing the changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elasticmachine @mauri870 @pierrehilbert @rdner @andrzej-stencel