Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 4, 2025

Proposed commit message

ObserverLogs is relying on a testing package in a non-test package

move to logptest

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #45734 done by [Mergify](https://mergify.com).

* refactor: replace lopg.ObserverLogs with logptest

ObserverLogs is relying on a testing package in a non-test package

move to logptest

* lint: regenerate notice file

* test: update to NewTestingLoggerWithObserver

* lint: regenerate notice

* lint: remove unused imports

* lint: remove unused imports

* Update console_test.go

* lint: fix linter issues

(cherry picked from commit b5789af)

# Conflicts:
#	filebeat/input/filestream/config_test.go
#	filebeat/input/journald/pkg/journalctl/reader_test.go
#	libbeat/autodiscover/autodiscover_test.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 4, 2025
@mergify mergify bot requested review from a team as code owners November 4, 2025 16:47
@mergify mergify bot removed the request for review from a team November 4, 2025 16:47
@mergify mergify bot requested review from khushijain21 and orestisfl November 4, 2025 16:47
@mergify
Copy link
Contributor Author

mergify bot commented Nov 4, 2025

Cherry-pick of b5789af has failed:

On branch mergify/bp/8.19/pr-45734
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit b5789af35.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   heartbeat/monitors/logger/logger_test.go
	modified:   heartbeat/monitors/wrappers/wrappers_test.go
	modified:   libbeat/monitoring/report/log/log_test.go
	modified:   packetbeat/npcap/npcap_test.go
	modified:   x-pack/metricbeat/module/gcp/metrics/metrics_requester_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   filebeat/input/filestream/config_test.go
	both modified:   filebeat/input/journald/pkg/journalctl/reader_test.go
	both modified:   libbeat/autodiscover/autodiscover_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2025
@github-actions github-actions bot added Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Security-Linux Platform Linux Platform Team in Security Solution labels Nov 4, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 4, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Security-Linux Platform Linux Platform Team in Security Solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants