Skip to content

Conversation

@belimawr
Copy link
Contributor

@belimawr belimawr commented Nov 6, 2025

Proposed commit message

Use logp.NewNopLogger on TestRunnerFactoryWithCommonInputSettings to avoid panic: "
Log in goroutine after TestRunnerFactoryWithCommonInputSettings has completed"

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

go test -v -count=1 -run=TestRunnerFactoryWithCommonInputSettings ./filebeat/channel

## Related issues
## Use cases
## Screenshots
## Logs

Use logp.NewNopLogger on TestRunnerFactoryWithCommonInputSettings to
avoid panic: "
Log in goroutine after TestRunnerFactoryWithCommonInputSettings has
completed"
@belimawr belimawr self-assigned this Nov 6, 2025
@belimawr belimawr requested a review from a team as a code owner November 6, 2025 20:50
@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 6, 2025
@belimawr belimawr added backport-active-all Automated backport with mergify to all the active branches skip-changelog labels Nov 6, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 6, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants