Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 12, 2025

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

To see the new behaviours, run

$ go test -v -run TestCache/get_missing_value             
=== RUN   TestCache
=== RUN   TestCache/get_missing_value
    logger.go:146: 2025-11-11T13:52:13.671+1030	INFO	cache	initialized cache processor	{"instance_id": 1, "details": "cache=[operation=get, store_id=memory:aidmaster, key_field=crowdstrike.aid, target_field=crowdstrike.metadata_new, ignore_missing=true, ignore_failure=false, overwrite_fields=false]"}
    cache_test.go:662: cache=[operation=get, store_id=memory:aidmaster, key_field=crowdstrike.aid, target_field=crowdstrike.metadata_new, ignore_missing=true, ignore_failure=false, overwrite_fields=false]
    logger.go:146: 2025-11-11T13:52:13.672+1030	DEBUG	cache	get	{"instance_id": 1, "backend_id": "memory:aidmaster", "config": {"Key":"crowdstrike.aid","Target":"crowdstrike.metadata_new"}}
    logger.go:146: 2025-11-11T13:52:13.672+1030	DEBUG	cache	get	{"instance_id": 1, "backend_id": "memory:aidmaster", "key": "one"}
=== RUN   TestCache/get_missing_value_ignore_error
    logger.go:146: 2025-11-11T13:52:13.672+1030	INFO	cache	initialized cache processor	{"instance_id": 2, "details": "cache=[operation=get, store_id=memory:aidmaster, key_field=crowdstrike.aid, target_field=crowdstrike.metadata_new, ignore_missing=true, ignore_failure=true, overwrite_fields=false]"}
    cache_test.go:662: cache=[operation=get, store_id=memory:aidmaster, key_field=crowdstrike.aid, target_field=crowdstrike.metadata_new, ignore_missing=true, ignore_failure=true, overwrite_fields=false]
    logger.go:146: 2025-11-11T13:52:13.672+1030	DEBUG	cache	get	{"instance_id": 2, "backend_id": "memory:aidmaster", "config": {"Key":"crowdstrike.aid","Target":"crowdstrike.metadata_new"}}
    logger.go:146: 2025-11-11T13:52:13.672+1030	DEBUG	cache	get	{"instance_id": 2, "backend_id": "memory:aidmaster", "key": "one"}
    logger.go:146: 2025-11-11T13:52:13.672+1030	DEBUG	cache	ignoring get error	{"instance_id": 2, "backend_id": "memory:aidmaster", "error": "metadata not found for 'one' in memory:aidmaster: metadata not found"}
    logger.go:146: 2025-11-11T13:52:13.672+1030	DEBUG	cache	no match	{"instance_id": 2, "backend_id": "memory:aidmaster", "error": "field in key_field not found in the event"}
--- PASS: TestCache (0.00s)
    --- PASS: TestCache/get_missing_value (0.00s)
    --- PASS: TestCache/get_missing_value_ignore_error (0.00s)
PASS

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #47565 done by [Mergify](https://mergify.com).

@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 12, 2025
@mergify mergify bot requested review from a team as code owners November 12, 2025 21:34
@mergify mergify bot assigned efd6 Nov 12, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Nov 12, 2025

Cherry-pick of 637949b has failed:

On branch mergify/bp/8.19/pr-47565
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 637949be4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/fragments/1762831091-s6615-cache.yaml
	modified:   libbeat/processors/cache/cache.go
	modified:   libbeat/processors/cache/cache_test.go
	modified:   libbeat/processors/cache/config.go
	modified:   libbeat/processors/cache/docs/cache.asciidoc

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/reference/filebeat/add-cached-metadata.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from khushijain21 and leehinman and removed request for a team November 12, 2025 21:34
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 12, 2025
@github-actions github-actions bot added enhancement Team:Security-Service Integrations Security Service Integrations Team labels Nov 12, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 12, 2025
Copy link
Contributor

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM!

@mergify
Copy link
Contributor Author

mergify bot commented Nov 13, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.19/pr-47565 upstream/mergify/bp/8.19/pr-47565
git merge upstream/8.19
git push upstream mergify/bp/8.19/pr-47565

@mergify
Copy link
Contributor Author

mergify bot commented Nov 17, 2025

This pull request has not been merged yet. Could you please review and merge it @efd6? 🙏

efd6 added 2 commits November 18, 2025 12:40
…on (#47565)

(cherry picked from commit 637949b)

# Conflicts:
#	docs/reference/filebeat/add-cached-metadata.md
* move changelog entry to global file
* remove markdown documentation
@efd6 efd6 force-pushed the mergify/bp/8.19/pr-47565 branch from a81d55f to 89edf2d Compare November 18, 2025 02:10
@efd6 efd6 enabled auto-merge (squash) November 18, 2025 02:12
@efd6
Copy link
Contributor

efd6 commented Nov 18, 2025

/test

@mergify
Copy link
Contributor Author

mergify bot commented Nov 24, 2025

This pull request has not been merged yet. Could you please review and merge it @efd6? 🙏

@efd6
Copy link
Contributor

efd6 commented Nov 28, 2025

/test

@mergify
Copy link
Contributor Author

mergify bot commented Dec 1, 2025

This pull request has not been merged yet. Could you please review and merge it @efd6? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Dec 4, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.19/pr-47565 upstream/mergify/bp/8.19/pr-47565
git merge upstream/8.19
git push upstream mergify/bp/8.19/pr-47565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request enhancement Team:Security-Service Integrations Security Service Integrations Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants