Skip to content

Conversation

@ash-darin
Copy link

@ash-darin ash-darin commented Nov 26, 2025

Proposed commit message

Fix Docker values to take into account floating point numbers

Metricbeat outputs floats, as evident here: Link to source that produces these values, as these are not absolute values but values for a fraction of a time ("per_second").

But with the exception of the "dropped" values, these are treated as long and therefore simply truncated. To preserve the values to a certain degree, treat all incoming ("in") and outgoing ("out") values as floats, like "dropped".

In GO, float64 is a IEEE754 conforming 64bit floating point number.
in Elastricsearch double is a IEEE754 conforming 64bit floating point number.

Therefore mapping these values to double is the closest match to any possible values produced by metricbeat.

Checklist

  • My code follows the style guidelines of this project

Disruptive User Impact

This should not disrupt user experience.

Use cases

You can now evaluate the values with a higher degree of accuracy.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 26, 2025
@github-actions
Copy link
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ash-darin? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ash-darin ash-darin changed the title Accept Float values as float fix(metricbeat): Accept Float values as float Nov 26, 2025
@ash-darin ash-darin changed the title fix(metricbeat): Accept Float values as float fix(metricbeat): Accept Float values as float not long Nov 26, 2025
@ash-darin ash-darin marked this pull request as ready for review November 26, 2025 10:16
@ash-darin ash-darin requested a review from a team as a code owner November 26, 2025 10:16
Restore bytes designation
Changes values to double to more closely match origin filetype float64. botch double in elasticearch and float64 in GO are IEEE754 conforming 64bit floats.
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Nov 30, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants