fix(metricbeat): Accept Float values as float not long #47792
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make floats into floats
Accept floatingpoint values as float
botelastic
bot
added
the
needs_team
Contributor
🤖 GitHub commentsJust comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
ash-darin
changed the title
ash-darin
changed the title
Restore bytes designation
Changes values to double to more closely match origin filetype float64. botch double in elasticearch and float64 in GO are IEEE754 conforming 64bit floats.
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fix Docker values to take into account floating point numbers
Metricbeat outputs floats, as evident here: Link to source that produces these values, as these are not absolute values but values for a fraction of a time ("per_second").
But with the exception of the "dropped" values, these are treated as long and therefore simply truncated. To preserve the values to a certain degree, treat all incoming ("in") and outgoing ("out") values as floats, like "dropped".
In GO, float64 is a IEEE754 conforming 64bit floating point number.
in Elastricsearch double is a IEEE754 conforming 64bit floating point number.
Therefore mapping these values to double is the closest match to any possible values produced by metricbeat.
Checklist
Disruptive User Impact
This should not disrupt user experience.
Use cases
You can now evaluate the values with a higher degree of accuracy.