Skip to content

Fix flaky TestNegativeCases in cometd input (#47698) #47820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −8
Open

Fix flaky TestNegativeCases in cometd input (#47698) #47820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67db933
Fix flaky TestNegativeCases in cometd input (#47698)
orestisfl Nov 28, 2025
83b933a
Merge branch 'main' into fix-flaky-TestNegativeCases
orestisfl Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions x-pack/filebeat/input/cometd/input.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ func (in *cometdInput) Run() {
in.workerOnce.Do(func() {
in.workerWg.Add(1)
go func() {
in.log.Info("Input worker has started.")
defer in.log.Info("Input worker has stopped.")
defer in.workerWg.Done()
defer in.workerCancel()
in.log.Info("Input worker has started.")
defer in.log.Info("Input worker has stopped.")
in.b = bay.Bayeux{}

rt := rate.NewLimiter(rate.Every(retryInterval), 1)
Expand Down
12 changes: 6 additions & 6 deletions x-pack/filebeat/input/cometd/input_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,6 @@ func newTestServer(URL string, handler http.Handler) (*httptest.Server, error) {
}

func TestNegativeCases(t *testing.T) {
t.Skip("https://github.com/elastic/beats/issues/47698")
expectedHTTPEventCount = 1
defer atomic.StoreUint64(&called, 0)
eventsCh := make(chan beat.Event)
Expand Down Expand Up @@ -582,13 +581,14 @@ func TestNegativeCases(t *testing.T) {
require.NotNil(t, input)

input.Run()
go func() {
<-eventsCh
assert.Error(t, fmt.Errorf("there should be no events"))
}()

// wait for run to return error or event
time.Sleep(100 * time.Millisecond)
select {
case <-eventsCh:
t.Error("expected no events, but received one")
case <-time.After(100 * time.Millisecond):
// Expected: no events received.
}

input.Stop()
}
Expand Down