Skip to content

cleanup(otel): move otelbeat packages to x-pack/otel #47873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

cleanup(otel): move otelbeat packages to x-pack/otel #47873

wants to merge 6 commits into from

Conversation

@mauri870
Copy link
Member

@mauri870 mauri870 commented Dec 2, 2025 •
edited
Loading

Proposed commit message

Move the remaining otelbeat packages to x-pack/otel so that all otel-related code is centralized.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

How to test this PR locally

cd x-pack/filebeat
mage goIntegTest

cd x-pack/metricbeat
mage goIntegTest

Related issues

@mauri870 mauri870 self-assigned this Dec 2, 2025
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-active-all Automated backport with mergify to all the active branches skip-changelog labels Dec 2, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mauri870 mauri870 force-pushed the rellocate-xpack-otel branch from 61955a4 to 38a3c97 Compare December 3, 2025 11:20
@mauri870
Copy link
Member Author

mauri870 commented Dec 3, 2025

/test

@mauri870
Copy link
Member Author

mauri870 commented Dec 3, 2025

/test

@mauri870 mauri870 marked this pull request as ready for review December 3, 2025 12:55
@mauri870 mauri870 requested review from a team as code owners December 3, 2025 12:55
@mauri870 mauri870 requested review from VihasMakwana and faec December 3, 2025 12:55
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Member Author

mauri870 commented Dec 3, 2025

Some intermittent agent lost failures are occurring in CI. It seems to be a widespread issue on Buildkite.

@mauri870
Copy link
Member Author

mauri870 commented Dec 3, 2025

/test

cmacknz
cmacknz reviewed Dec 3, 2025
View reviewed changes
x-pack/otel/beatconverter/beatconverter.go
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
Copy link
Member

@cmacknz cmacknz Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate from this PR I think we can get rid of beatconverter and oteltranslate in this repository, created #47904 to track that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz cmacknz left review comments

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

At least 1 approving review is required to merge this pull request.

Assignees

@mauri870 mauri870

Labels

backport-active-all Automated backport with mergify to all the active branches skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mauri870 @elasticmachine @cmacknz