Config: Allow escaping dots in keys via '[unsplit.key]' syntax #8512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
buildkite test this -f p=gke,s=8.17.3,t=TestFleet |
pebrc
reviewed
Mar 7, 2025
|
|
||
| // Options are config options for the YAML file. Currently contains only support for dotted keys. | ||
| var Options = []ucfg.Option{ucfg.PathSep("."), ucfg.AppendValues} | ||
| var Options = []ucfg.Option{ucfg.PathSep("."), ucfg.AppendValues, ucfg.EscapePath()} |
Collaborator
There was a problem hiding this comment.
Should this generally be enabed or only in Kibana that supports the escape syntax?
Contributor
Author
There was a problem hiding this comment.
I'm not sure how to make this specific to Kibana tbh, this Options is used in a lot of places, including receivers like MergeWith or HasKeys ... I can change all these functions so they accept an "optional Options". On the other hand I think it should be fine to enable this for other applications, even if they are not compatible with this syntax?
pebrc
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to escape dots in paths, similar to what Kibana supports since elastic/kibana#178841
Relates to #8499