Skip to content

Helm release tool: Add an option to force upload #8771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 29, 2025

Conversation

barkbay
Copy link
Contributor

@barkbay barkbay commented Jul 29, 2025

This PR adds an option to upload Helm artifacts even if isNonSnapshot && isProdHelmRepo

@prodsecmachine
Copy link
Collaborator

prodsecmachine commented Jul 29, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@botelastic botelastic bot added the triage label Jul 29, 2025
@barkbay barkbay added :helm-charts >enhancement Enhancement of existing functionality exclude-from-release-notes Exclude this PR from appearing in the release notes v3.1.0 labels Jul 29, 2025
@botelastic botelastic bot removed the triage label Jul 29, 2025
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barkbay barkbay requested a review from thbkrkr July 29, 2025 13:40
Co-authored-by: Michael Montgomery <[email protected]>
Copy link
Contributor

@naemono naemono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for this.

Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barkbay barkbay enabled auto-merge (squash) July 29, 2025 14:25
Copy link
Contributor

@thbkrkr thbkrkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 👌 👌 😅

@barkbay barkbay merged commit 7507da6 into elastic:3.1 Jul 29, 2025
9 checks passed
barkbay added a commit to barkbay/cloud-on-k8s that referenced this pull request Jul 29, 2025
* Helm release tool: Add an option to force upload

* Also use shouldNotOverwrite when checking the error

* Update hack/helm/release/cmd/root.go

Co-authored-by: Michael Montgomery <[email protected]>

* Read FORCE in hack/helm/release/trigger-helm-release.sh

* Update hack/helm/release/trigger-helm-release.sh

Co-authored-by: Thibault Richard <[email protected]>

* make FORCE optional

---------

Co-authored-by: Michael Montgomery <[email protected]>
Co-authored-by: Thibault Richard <[email protected]>
barkbay added a commit that referenced this pull request Jul 30, 2025
* Helm release tool: Add an option to force upload

* Read FORCE in hack/helm/release/trigger-helm-release.sh

---------

Co-authored-by: Michael Montgomery <[email protected]>
Co-authored-by: Thibault Richard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality exclude-from-release-notes Exclude this PR from appearing in the release notes :helm-charts v3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants