-
Notifications
You must be signed in to change notification settings - Fork 768
Helm release tool: Add an option to force upload #8771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Michael Montgomery <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Thanks for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Thibault Richard <[email protected]>
…-helm-force-option
Co-authored-by: Thibault Richard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 👌 👌 😅
* Helm release tool: Add an option to force upload * Also use shouldNotOverwrite when checking the error * Update hack/helm/release/cmd/root.go Co-authored-by: Michael Montgomery <[email protected]> * Read FORCE in hack/helm/release/trigger-helm-release.sh * Update hack/helm/release/trigger-helm-release.sh Co-authored-by: Thibault Richard <[email protected]> * make FORCE optional --------- Co-authored-by: Michael Montgomery <[email protected]> Co-authored-by: Thibault Richard <[email protected]>
* Helm release tool: Add an option to force upload * Read FORCE in hack/helm/release/trigger-helm-release.sh --------- Co-authored-by: Michael Montgomery <[email protected]> Co-authored-by: Thibault Richard <[email protected]>
This PR adds an option to upload Helm artifacts even if
isNonSnapshot && isProdHelmRepo